Add codespell config and workflow (to detect new typos) + fix some typos

koumoul-dev / vuetify-jsonschema-form

Create beautiful and low-effort forms that output valid data. Published on npm as @koumoul/vjsf.

https://koumoul-dev.github.io/vuetify-jsonschema-form/latest/

MIT License

538 stars 154 forks source link

Add codespell config and workflow (to detect new typos) + fix some typos #429

Open yarikoptic opened 4 months ago

yarikoptic commented 4 months ago

A token of gratitude (or a bribe to facilitate review #428 ;) ): add https://github.com/codespell-project/codespell support and get some typos fixed.

TODOs:

[ ] decide if fixes to lib/utils/expr-eval-parser.js are ok since seems to fix there... looking at https://github.com/silentmatt/expr-eval/blob/HEAD/parser.d.ts#L22 (if I got the target interface right) -- seems to be correct fixes

albanm commented 4 months ago

Hello, thanks for the effort but I only do some minimal maintenance on this branch. The work is focused in the "next" branch.

What does the github action do ? Does it block if there are typos ? I like the functionality of codespell, but I don't know if it warrants bringing this extra complexity. It would be nice if it acted a bit like dependabot, just making suggestions in PRs.

yarikoptic commented 4 months ago

Hello, thanks for the effort but I only do some minimal maintenance on this branch. The work is focused in the "next" branch.

should I rebase?

What does the github action do ? Does it block if there are typos ?

it just fails CI -- you are still welcome to force the hand and merge the PR, but you better fix the typos and make it happy ;)

I like the functionality of codespell, but I don't know if it warrants bringing this extra complexity. It would be nice if it acted a bit like dependabot, just making suggestions in PRs.

no such convenience just yet ... may be in the future. But typically it is just a few typos, easy to review/fix and push a fix.