search

kouprlabs / voltaserve

⚡️ Cloud Storage for Creators
https://voltaserve.com
Other
257 stars 14 forks source link

Pre-commit hooks #134

Open loboda4450 opened 2 months ago

loboda4450 commented 2 months ago

As in my other project (click) I have configured pre-commit hooks that haven't allowed me to push to the repo if hooks were not successful. Actually I have literally 0 exprience in Go, but I believe this would be so beneficial. They could be also reflected in CIs.

bouassaba commented 2 months ago

From my side it sounds good, I used git hooks before, they automate code quality tasks pretty well. We could also ask the opinion of @dsonck92 on this, as he already setup for us golangci-lint, he must have great knowledge on this.

dsonck92 commented 2 months ago

Heh, well, I'm all for it. One outstanding point regarding golangci-lint specifically, there is a bug somewhere with the caching system, which may produce false positives. This is mostly triggered by the ireturn linter. There is some discussion on whether the ireturn linter is actually something you want as there are use cases where you do want to return an interface.

bouassaba commented 3 weeks ago

@loboda4450 @dsonck92 Do we still want to have this?