search

kourosh / tally-old

General Assembly final project
0 stars 0 forks source link

Add columns to Pol table (MB) #30

Closed kourosh closed 9 years ago

kourosh commented 9 years ago

The politician table currently only works for members of Congress. Need to modify table to take presidential and congressional candidates. Very likely, the fix is removing a "required" from the model.

ikitha commented 9 years ago

I checked the model and there are no validations regarding what we talked about. Can you take a look and let me know what we need to do to proceed?

kourosh commented 9 years ago

Huh, you’re right. There is no validation.

I think we still need to make some minor changes. Again, I made the underlying model by scraping some Congress APIs. All we need to do to accommodate presidential candidates is to change some of the column headings.

Here are the current headings: title, first name, middlename, last name, fullname, name_suffix, nickname, party, state, district, in_office, gender, phone, fax, website, webform, congress_office, bioguide_id, votesmart_id, fec_id, govtrack_id, crp_id, twitter_id, congresspedia_url, youtube_url, facebook_id, official_rss, senate_class, birthdate, oc_email

Changes: Add a column called current_office. Add validation to accommodate only these possibilities: House of Reps, Senator, Governor, State Senator, State Rep, Mayor, none. Delete “in-office”. I think its boolean Add column “personal_website” Add column “primary_donation_website”

That should do the trick for now.

Can you also update the forms to create a new candidate? I need to create a whole bunch for president.

On Feb 17, 2015, at 11:32 AM, Myla Baker notifications@github.com wrote:

I checked the model and there are no validations regarding what we talked about. Can you take a look and let me know what we need to do to proceed?

— Reply to this email directly or view it on GitHub https://github.com/kourosh/tally/issues/30#issuecomment-74735687.

ikitha commented 9 years ago

I already changed the form to what I could. I'll make these changes now :) Also need to figure out superuser validation because i had to turn off devise for that page because it was making me sign up or log in... so devise is working haha

ikitha commented 9 years ago

This should be fixed. Let me know if something else needs to be changed.