koursaros-ai / nboost

NBoost is a scalable, search-api-boosting platform for deploying transformer models to improve the relevance of search results on different platforms (i.e. Elasticsearch)
Apache License 2.0
675 stars 69 forks source link

fixed reranking error as ranks are bigger than choices. Issue#77 Search query not working... #78

Closed SagarPalyal closed 4 years ago

SagarPalyal commented 4 years ago

The issue was with search queries as I have mentioned in open issue #77 Search query not working . It was re ranking issue where number of ranks are higher than choices. This change is to fix that problem. Now search query is retrieving results without any issue. @pertschuk

Previously:

  1. Error if providing query as well Eg: Nboost (Not Working) : http://localhost:8000//_search?q=
  2. Error if no source value provided Eg : Nboost (Not Working) : http://localhost:8000//_search?q=&_source=
  3. Error if more than one source provided Eg : Nboost (Not Working) : http://localhost:8000//_search?q=&_source=,

All the above scenarios are fixed now and working with this change.

pertschuk commented 4 years ago

Thanks !