search

koush / electron-chrome

Other
970 stars 68 forks source link

Support for Chrome Extensions? #9

Closed Nantris closed 8 years ago

Nantris commented 8 years ago

I tried running this on a Chrome Extension and I get the following:

using chrome runtime 1.0.0.3
starting chrome app at ../build
chrome app id aliibbbfcilolackhjmkgdikmipbiemp
starting runtime
[39664:0903/171506:INFO:CONSOLE(15)] "appId aliibbbfcilolackhjmkgdikmipbiemp", source: C:\Projects\Recall-ext\electron-chrome\chrome\api \chrome-runtime.js (15)
[39664:0903/171506:INFO:CONSOLE(39)] "chrome runtime started", source: C:\Projects\Recall-ext\electron-chrome\chrome\api\chrome-runtime.js (39)
[39664:0903/171506:INFO:CONSOLE(263)] "initialized", source: C:\Projects\Recall-ext\electron-chrome\chrome\api\chrome-runtime.js (263)
[39664:0903/171506:INFO:CONSOLE(64)] "creating window", source: C:\Projects\Recall-ext\electron-chrome\chrome\api\chrome-app.js (64)
[39664:0903/171506:INFO:CONSOLE(230)] "Uncaught (in promise) TypeError: Cannot read property 'background' of undefined", source: C:\Projects\Recall-ext\electron-chrome\chrome\api\chrome-runtime.js (230)

I know this wasn't created for converting apps, but could it be done with minor modification or would it be a big project?

koush commented 8 years ago

No plans, chrome extensions aren't going anywhere, and would require building a whole browser experience anyways.

Nantris commented 8 years ago

My Chrome extension acts exactly like an app, it uses a popup window, it has no interaction with Chrome's extension tray area, other pages or features of chrome (outside of local storage) and doesn't use anything that's specific to extensions. Everything I'm using is supported in Chrome apps to my knowledge.

It acts somewhat like Join by joaoapps

Would there be a huge barrier to me trying to get this to work on my own? Would it be an undertaking or just some tweaking? If you have any idea where to start, I'd appreciate it. I might try to fork this.

Thanks!

jarrodek commented 8 years ago

The app is using apps specific APIs like tcp.sockets, filesystem access (user data on drive) etc. Chrome extensions do not have this permissions and therefore a number of changes must be made in the app to adjust it to become Chrome extension. Also It would require to create a new item in CWS since there's no way to change the type of app. Right now it's not in the roadmap to move the app to the extensions platform but rather outside Chrome ecosystem.