search

koush / ion

Android Asynchronous Networking and Image Loading
Other
6.29k stars 1.03k forks source link

Fatal Exception with no explanations only with gradle 4.1.0 #937

Closed Helma-T closed 4 years ago

Helma-T commented 4 years ago

My app works perfectly fine with ION but after upgrading the app from grade 3.5.1 to 4.1.0, it gives below fatal exception. I tested and the app works fine until gradle 4.0.2. The problem is only with 4.1.0

2020-10-16 16:33:15.295 22067-22127/[MYAPP] E/AndroidRuntime: FATAL EXCEPTION: ion-ion Process: [MYAPP], PID: 22067 java.lang.AssertionError at com.koushikdutta.async.AsyncSSLSocketWrapper.write(AsyncSSLSocketWrapper.java:390) at com.koushikdutta.async.AsyncSSLSocketWrapper.handleHandshakeStatus(AsyncSSLSocketWrapper.java:276) at com.koushikdutta.async.AsyncSSLSocketWrapper.handshake(AsyncSSLSocketWrapper.java:114) at com.koushikdutta.async.http.AsyncSSLSocketMiddleware.tryHandshake(AsyncSSLSocketMiddleware.java:91) at com.koushikdutta.async.http.AsyncSSLSocketMiddleware$2.onConnectCompleted(AsyncSSLSocketMiddleware.java:108) at com.koushikdutta.async.AsyncServer.runLoop(AsyncServer.java:849) at com.koushikdutta.async.AsyncServer.run(AsyncServer.java:658) at com.koushikdutta.async.AsyncServer.access$800(AsyncServer.java:44) at com.koushikdutta.async.AsyncServer$14.run(AsyncServer.java:600)

serrokitskiy commented 4 years ago

I have also updated 'com.android.tools.build:gradle:4.0.2' to 'com.android.tools.build:gradle:4.1.0' and am getting the same error.

mathislaurentpiquoti commented 4 years ago

same problem for me but you can use the lib if you set debuggable to false in your gradle app variant

akhilakhi84 commented 4 years ago

Finally i found a soultion

Solution 1: Go to: File > Invalidate Caches/Restart and select Invalidate and Restart

Solution 2: Go to: Build > Select Build Variant and select release instead of debug

JuliCodes commented 4 years ago

I also run into the error. According to https://developer.android.com/studio/releases/gradle-plugin?hl=de the new gradle version the compiler rewrites the app code in debug mode: “ Assertions in debug builds

When you build the debug version of your app using Android Gradle plugin 4.1.0 and higher, the built-in compiler (D8) will rewrite your app's code to enable assertions at compile time, so you always have assertion checks active.”

actor10 commented 4 years ago

That means we can't debug apps with ION with Gradle is at 4.1.0? That seems unfortunate.

koush commented 4 years ago

I'm preparing an update that will remove the asserts.

koush commented 4 years ago

Fixed in 3.1.0 please confirm

JuliCodes commented 4 years ago

It works now at my end. - Thanks!

actor10 commented 4 years ago

Yes, it's working. Thank you very much.

(Sorry for the delay, I had been dragging my feet on upgrading my project in Studio.)

Henry

On Sun, Nov 8, 2020 at 3:33 AM Koushik Dutta notifications@github.com wrote:

Fixed in 3.1.0 please confirm

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/koush/ion/issues/937#issuecomment-723546242, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABK7C5UOTSDWCC3FOOG7FHLSOZJUPANCNFSM4SRYRNSQ .