search

koush / nvr.scrypted.app

15 stars 0 forks source link

Paid Scrypted overdiscovers #30

Open asosnovsky opened 6 months ago

asosnovsky commented 6 months ago

So I've been using Scrypted as my main nvr for a few months now, and just recently bought the official nvr subscription (which is by the way so underpriced 🙂 ).

While using the paid version, it seems to me that the Scrypted autodiscovery possibly lacks some caching or a solid identifier for cameras already seen.

The first time I used it I ended up adding the same 3 cameras like 4 times because I thought it lost my credentials or something.

I suspect that this could be due to the fact that I have my cameras on a custom dns (eg garage.cam.internal, baby.cam.internal etc), though the autodiscovery did made me add the same camera twice via ip through both onvif and amcrest.

May I suggest that

  1. Make it more clear in the banner (especially for new comers) that the dialog is for newly discovered devices, right now it's too easy to misunderstand it.

  2. Pretty sure you should be able to dedup "discoveries" by utilizing the MAC address and resolve any custom domain names

Anyhow, I would love to help contribute if you can point me to the direction. Thank you so much for an awesome project!

koush commented 6 months ago

Currently deduping is based on ip, serial number, and Mac address. The latter 2 need to be provided via the camera API and are not always present or reliable. If you entered domains, then yes the IPs would be considered unique.