search

koush / nvr.scrypted.app

15 stars 0 forks source link

Can't scroll back through time when viewing portrait camera in nvr on mobile #6

Closed cnelson-pdx closed 10 months ago

cnelson-pdx commented 1 year ago

I can provide a screenshot if necessary. Two of my cameras are portrait and record/work fine on desktop as well as in landscape on mobile.

Behavior could be improved by tapping or pulling up on the camera name to show the timeline and cover half the camera feed to allow for viewing and panning in feed and scrolling timeline.

koush commented 1 year ago

screenshot or video would be useful yes, not sure what you are referring to

koush commented 1 year ago
image
koush commented 11 months ago

Fixed. Aspect ratios will be forced to 16:9 or 4:3 range to ensure UI issues like this don't occur.

Other fix considered was having the UI start in a zoomed state, but that was decided against. It's generally fine to stretch camera views, since the camera encoded resolution to FOV is not a true anyways.

niallobr commented 10 months ago

My Arlo doorbell provides a 1:1 ratio stream. It seems to be getting stretched to 16:9 now. I think the UI was ok before when it appeared square, so maybe 1:1 could be allowed too? Or if it can be shown as 16:9 with black bars either side instead of being stretched out?

niallobr commented 10 months ago

Just dropping a tag @koush since this issue is technically closed and my comment above about the 1:1 aspect ratio might have been missed.

koush commented 10 months ago

@niallobr can you provide a screenshot

niallobr commented 10 months ago

Sure @koush, thank you.

homekit nvr2 nvr1

koush commented 10 months ago

The app has been changed to fit between 16:9 to 4:3. These are common ratios. This is 4:3. your 1:1 cam is being stretched to that aspect ratio.

But your 1:1 is also a stretched resolution, you can see the fisheye and compression effect.

Unfortunately due to wide variety in camera fov and encoding resolution, choices need to be made or fit into a common ui. I think using common aspect ratio caps is the best solution here.

for example, shorter resolution phones would have less timeline visible in 1:1.

niallobr commented 10 months ago

@koush A fisheye lens is distorted in a uniform manner though. This is stretching the video from 2 sides only which always looks more unnatural than a panoramic effect (like fisheye) to me. I do accept that 1:1 is an unusual aspect ratio to deal with in general though. A good compromise might be if at some point if 1:1 feeds could appear inside the 4:3 or 16:9 frame at their natural ratio with black bars instead of stretching. The nearest example I can think of would be how the background-size CSS property works with a contain value set. Attached a mockup of how that might look.

nvr2-mockup