core: clear local url converter cache after 10m

koush / scrypted

Scrypted is a high performance video integration and automation platform

https://scrypted.app

Other

4.32k stars 255 forks source link

core: clear local url converter cache after 10m #1595

Closed bjia56 closed 1 month ago

bjia56 commented 1 month ago

Stopgap fix for excessive memory usage when something repeatedly converts to a LocalUrl media type

koush commented 1 month ago

can you check the usage of converting to this type in tree to verify other plugins aren't using it for long term urls? I don't think anything is off hand.

bjia56 commented 1 month ago

Usage I see:

Converting text to audio in notifier-mixin: https://github.com/koush/scrypted/blob/adf4e797c12df535933745f26743dd4960ad5731/plugins/notifier-mixin/src/main.ts#L11
Converting images/audio in chromecast: https://github.com/koush/scrypted/blob/adf4e797c12df535933745f26743dd4960ad5731/plugins/chromecast/src/main.ts#L176-L187

Seems like these are then sent to external services, which presumably will load the content near-immediately?

bjia56 commented 1 month ago

I'd be ok with extending the timeout to 5m or so as well, as you mentioned in Discord

koush commented 1 month ago

yeah 10m is good