This change spins off from conversation at https://github.com/scryptedapp/homeassistant/pull/1 and allows consumers of the Notifier interface to specify a channel for notifications to be sent to. Android platforms can use this to send notifications to a specific channel, allowing the user to have fine-grained control over the audio and priority of the notifications they receive.
I'm not certain my automation-actions.ts edit is enough to make this work, I didn't readily see where these were consumed in the codebase.
Potential TODOs:
Consumers of Notifier that might want to set a channel:
Also, I'm not seeing where the results of the object detection are obtained in relation to conditional notifications, so that will still want to set a channel
Implementations of Notifier that might be able to consume the channel:
This change spins off from conversation at https://github.com/scryptedapp/homeassistant/pull/1 and allows consumers of the
Notifier
interface to specify a channel for notifications to be sent to. Android platforms can use this to send notifications to a specific channel, allowing the user to have fine-grained control over the audio and priority of the notifications they receive.I'm not certain my
automation-actions.ts
edit is enough to make this work, I didn't readily see where these were consumed in the codebase.Potential TODOs:
manage.scrypted.app
- Should the frontend test notification set a channel oftesting
or should it stay with the general channel? https://github.com/koush/manage.scrypted.app/blob/168317f6790e7012560e7d2bb755c6fd03c0a308/src/components/interfaces/Notifier.vue#L97scryptedapp/notifier-zone-filter
- https://github.com/scryptedapp/notifier-zone-filter/blob/64d1d8130912ccab73c4e360db5cce757ccea1d6/src/main.py#L457 and https://github.com/scryptedapp/notifier-zone-filter/blob/64d1d8130912ccab73c4e360db5cce757ccea1d6/src/main.py#L460scryptedapp/securitysystem
- https://github.com/scryptedapp/securitysystem/blob/cd82bbde8a2414e738a035248e4646c3102e3221/src/main.ts#L129