search

koute / libretro-sys

Raw FFI bindings to the libretro API
MIT License
6 stars 7 forks source link

add vulkan support #4

Open FlorianUekermann opened 5 years ago

FlorianUekermann commented 5 years ago

Fixes #3

This adds a translation the libretro vulkan headers. I've been sitting on this for a while, because I wanted to make sure it is actually usable (even a simple vulkan test requires ~1k loc). It uses ash::vk as vulkan "sys" package, because it seems to be the most actively maintained & popular, as well as the only one I can personally recommend.

I am fairly new to Rust and this is my first code contribution in Rust... so if something looks a bit off, I would appreciate the feedback.

I put my name in the authors list on the toml. Not sure if that is recommended practice for drive-by contributions. If that field isn't supposed to be an exhaustive list of contributors, lets remove my name. I also wasn't sure which part of the version should be incremented, so I didn't touch it.

koute commented 5 years ago

Oh and, I'll increment the version myself once this gets merged, so don't worry about it. (:

FlorianUekermann commented 5 years ago

Done. Couldn't derive Debug for HwRenderInterface automatically, due to a function pointer field.

FlorianUekermann commented 5 years ago

@koute I lost track of this for a bit... I think I the latest commit addressed the style issues you raised. Are you going to merge this or should I close this PR and package it separately? I've been using the crate in this state for a while now and it works fine.