search

koute / not-perf

A sampling CPU profiler for Linux
Apache License 2.0
871 stars 41 forks source link

Update gimli and addr2line #5

Closed philipc closed 5 years ago

philipc commented 5 years ago

This updates to gimli 0.17.0. We still need a new addr2line release before this can be merged though.

The gimli register definitions could be used more extensively, but it's still missing some of the definitions you have (eg MIPS).

koute commented 5 years ago

Thanks for the PR!

The only comment I have is that it'd be nice if you'd move the Cargo.lock changes into a separate commit (as I like to keep those separate); otherwise looks good to me!

koute commented 5 years ago

Thanks!