Open koute opened 6 years ago
Please consider dropping the "stable ID" guarantee for 0.5.0
- we can provide an explicit "stable ID" api for users who need it, and it will remove the core dependency on WeakMap
.
The following APIs are not actually web APIs, they are instead JavaScript APIs:
stdweb::web::Date
stdweb::web::TypedArray
stdweb::web::ArrayBuffer
stdweb::web::error::IError
stdweb::web::error::Error
stdweb::web::error::TypeError
Therefore they should be moved into core
.
I believe the above list is thorough, but I might have missed a couple APIs.
@Pauan I think you can add SecurityError
to that list.
@vitiral But SecurityError
is a DOM error, right? Am I missing something?
Bump -- any ETA on this at all? Especially the first one; it's mildly annoying to keep around extra copies of the same trait, now that it's been standardized.
@nic-hartley I have this work started on a private branch, but it's currently on the backburner.
@koute Anything you'd like help with? I've been using stdweb (and cargo web) lately; I'm happy to contribute back.
[ ] - (breaking change) Switch to upstream
TryInto
/TryFrom
. (This will require removing some blanket impl (e.g. forTryFrom< Value > for Option< T >
) and some concrete impls (e.g.From< Array > for Vec< Value >
needs to be removed due to Rust's coherence rules); it will also require converting someTryFrom
impls intoTryInto
impls (again - due to coherence rules) and modifying some trait bounds (e.g. inJsSerialize
impl for closures fromTryFrom
intoTryInto
)) [ ] - (possibly breaking change?) Movewebcore
into a separate crate. [ ] - (breaking change)IPointerEvent::{pressure, tangential_pressure}
should returnf32
. [ ] - (breaking change) AddMouseButton::Eraser
variant. (Rename it toButton6
maybe?) [ ] - (breaking change) Wrap subscription-like types with autodrop wrapper (EventListenerHandle
, etc.) [ ] - (should be non-breaking but might be) Switch from aWeakMap
to aMap
? [ ] - Add support for converting to/fromf32
. [ ] - (breaking change) Get rid ofget_
prefixes from the getters.(... possibly more ...)