The general functionality of ds-filter-fields might benefit from further detail as to how multiple values for one field can be part of the filtering of that field and how testing for the truthiness of a condition is the basis for filtering rather than just passing the actual list of values as the filter (in my mind, the latter would have been a more intuitive and simpler approach for the end-user).
Also, the documentation seems to have a bug related to the explanation.
The startsWithD function is going to return false all the time because startsWith('D') is always comparing a lowercase d with an uppercase D. I think the function was supposed to be value.toLowerCase().startsWith('d')?
kouts
commented
1 year ago
The general functionality of
ds-filter-fieldsmight benefit from further detail as to how multiple values for one field can be part of the filtering of that field and how testing for the truthiness of a condition is the basis for filtering rather than just passing the actual list of values as the filter (in my mind, the latter would have been a more intuitive and simpler approach for the end-user).Also, the documentation seems to have a bug related to the explanation.
The
startsWithDfunction is going to returnfalseall the time becausestartsWith('D')is always comparing a lowercase d with an uppercase D. I think the function was supposed to bevalue.toLowerCase().startsWith('d')?https://next--vue-dataset-demo.netlify.app/components/#props