kovacsv / JSModeler

A JavaScript framework to create and visualize 3D models.
MIT License
655 stars 123 forks source link

Adds basic support for .obj vertex colors #47

Closed k8stone closed 4 years ago

k8stone commented 4 years ago
k8stone commented 4 years ago

I just stumbled across JSModeler as I was looking for a quick way to preview .obj files for a personal project. What a fantastic asset! Thank you so much for pulling it together - I only needed a few small tweaks to be able to host CAD designs for a personal project, so I hope this proves to be a useful addition.

One thing it does not do is deal with faces whose vertexes disagree on their color, but it should gracefully degrade to using the default material in these cases.

kovacsv commented 4 years ago

Hi Kate,

Thanks for the improvement. I'd like to ask you to open a pull request for the development branch, because master is for released versions only.

For more information see this page: https://github.com/kovacsv/JSModeler/wiki/How-to-contribute-to-JSModeler%3F

Thanks, Viktor

k8stone commented 4 years ago

Will do.