kovacsv / occt-import-js

The emscripten interface for OpenCascade import functionalities.
GNU Lesser General Public License v2.1
141 stars 23 forks source link

Geometry incorrect using THREE.js example #14

Closed Glavin001 closed 1 year ago

Glavin001 commented 1 year ago

Reproduce

  1. Download STEP file from Downloads section in: https://www.servocity.com/stingray-2-servo-gearbox-0-34-sec-60-30rpm-700-oz-in-torque-900-rotation/
  2. Go to https://5hk66o.csb.app/
  3. Click Choose file and select the STEP file
  4. Wait, a long time (#8 ). Tell Chrome multiple times it is OK to wait instead of reload the page, if Chrome asks.
  5. See the results below.
Expected Observed
https://3dviewer.net/ https://5hk66o.csb.app/
image image
image :x: image

Context


Any help would be greatly appreciated!

Glavin001 commented 1 year ago

Faster/much smaller STEP example showing incorrect geometry

STEP file from: https://www.servocity.com/3-10-press-fit-wheel-2-pack/

Expected Observed
https://3dviewer.net/ https://5hk66o.csb.app/
image image
kovacsv commented 1 year ago

Indeed, the example was not prepared to handle this big index numbers. See this change for the fix: 43e54b498b2074e0884db287cb678d86798e3e84.

Glavin001 commented 1 year ago

Wow thank you for such a quick turnaround time to fix! 🎉