kovalev-sergey / homebridge-sony-audio

HomeKit integration for Sony Audio products
Apache License 2.0
14 stars 0 forks source link

STR-AZ5000ES fails API validation for getSystemInformation (1.4) as it uses 1.6 #36

Open ohmantics opened 1 year ago

ohmantics commented 1 year ago

Describe The Bug: STR-AZ5000ES is refused as incompatible

To Reproduce: Install plugin and restart Homebridge, failure is quickly logged

Expected behavior: Expected the receiver to be successfully supported. Patching api.js to expect 1.6 appears to make it work.

Logs:

[6/23/2023, 8:33:34 PM] [Sony Audio Platform] Launched child bridge with PID 10811
[6/23/2023, 8:33:34 PM] Registering platform 'homebridge-sony-audio.SonyAudio'
[6/23/2023, 8:33:34 PM] [Sony Audio Platform] Loaded homebridge-sony-audio v1.2.0 child bridge successfully
[6/23/2023, 8:33:34 PM] Loaded 0 cached accessories from cachedAccessories.0EA6DC8EE54C.
[6/23/2023, 8:33:34 PM] Homebridge v1.6.1 (HAP v0.11.1) (Sony Audio Platform) is running on port 55728.
[6/23/2023, 8:33:35 PM] [Sony Audio Platform] Incompatible device found, skipped: STR-AZ5000ES

When manually patched:

[6/23/2023, 8:30:20 PM] Registering platform 'homebridge-sony-audio.SonyAudio'
[6/23/2023, 8:30:21 PM] [Sony Audio Platform] Loaded homebridge-sony-audio v1.2.0 child bridge successfully
[6/23/2023, 8:30:21 PM] Homebridge v1.6.1 (HAP v0.11.1) (Sony Audio Platform) is running on port 55728.
[6/23/2023, 8:30:21 PM] [Sony Audio Platform] Adding new accessory: STR-AZ5000ES
[6/23/2023, 8:30:21 PM] [Sony Audio Platform] Compatible device found, added: STR-AZ5000ES
[6/23/2023, 8:30:22 PM] Homebridge v1.6.1 (HAP v0.11.1) (Nest) is running on port 48992.
[6/23/2023, 8:30:22 PM] STR-AZ5000ES 357C is running on port 39791.
[6/23/2023, 8:30:22 PM] Please add [STR-AZ5000ES 357C] manually in Home app. Setup Code: 123-45-678

Plugin Config:

        {
            "name": "Sony Audio Platform",
            "platform": "SonyAudio",
            "_bridge": {
                "username": "0E:A6:DC:xx:xx:xx",
                "port": 55728
            }
        }

Environment:

ohmantics commented 10 months ago

See discussion in https://github.com/rytilahti/python-songpal/issues/130 and https://github.com/rytilahti/python-songpal/pull/131.

willie commented 3 weeks ago

Any progress here? @ohmantics did you end up forking it?

ohmantics commented 3 weeks ago

@willie It's still patched on my machine. The bigger problem is that this model doesn't return inputs properly; it provides a list that's possibly correct for some other Sony device. I tried getting Sony to recognize their bug, but they've gone out of their way to be very unhelpful. Sony US claims these REST APIs are deprecated and they now prefer another API for integrators that's basically like serial control. Having worked at Sony I know that's not likely the plan in Japan and the problem is just telling the Japanese engineers about the bug to get it fixed. I got tired of tilting at windmills. The ES product line simply isn't what it once was.

willie commented 3 weeks ago

@ohmantics Thanks for the details, I appreciate it, even if that's not an ideal outcome.