Then, I noticed that there were some tests in test/gamma/test/constructors.cljs and matched the pattern to add tests for my new functions. But, I didn't see how to test it. I asked on gitter & didn't get a response, so I figured out one way to enable it. I hit a bunch of errors and fixed them all. This includes fixing up textureCubeLod. Hopefully this is at least a resonable start for doing this, I'm a bit of a n00b. Also, I've only tested this on my mac so far, though.
So, there's a bit of a mish-mash of updates in this pull request, but hopefully this explains how it came about.
kovasb
commented
8 years ago
I was converting a [https://github.com/ashima/webgl-noise/blob/master/src/noise3D.glsl](WebGL noise3d.glsl) function and found I needed min/max with vector types. So I added them.
Then, I noticed that there were some tests in test/gamma/test/constructors.cljs and matched the pattern to add tests for my new functions. But, I didn't see how to test it. I asked on gitter & didn't get a response, so I figured out one way to enable it. I hit a bunch of errors and fixed them all. This includes fixing up textureCubeLod. Hopefully this is at least a resonable start for doing this, I'm a bit of a n00b. Also, I've only tested this on my mac so far, though.
So, there's a bit of a mish-mash of updates in this pull request, but hopefully this explains how it came about.