kovasb / session

repl into the clojurescript community
Eclipse Public License 1.0
460 stars 36 forks source link

Update input in a loop. #8

Closed kapilreddy closed 11 years ago

kapilreddy commented 11 years ago

When one user enters input to evaluate. Other connected users get updated with evaluated input but not the input itself.

kapilreddy commented 11 years ago

The latest commit takes care of updating other user's input as you type.

kovasb commented 11 years ago

Thanks! We need some functionality like this.

I ran cljsbuild and tried the code.. something isn't working with creating the editor. See attached issue8bug

kapilreddy commented 11 years ago

Yeah I noticed that. Sorry about that. Should I close this issue and send one more pull request with extra fix?

kapilreddy commented 11 years ago

Just pushed the fix commit please check.

kovasb commented 11 years ago

Cool, the input area works now, and I see the echoing behavior across multiple connections to the session.

Now the problem is that all the return values are the empty string, "", no matter what the input is.

kapilreddy commented 11 years ago

I was experimenting with passing std-out along with evaluated input. Well its for another pull request I guess.

kovasb commented 11 years ago

Yeah, lets keep the std-out issue separate, its gonna take a little more thought.