koverstreet / bcachefs-tools

http://bcachefs.org
GNU General Public License v2.0
120 stars 89 forks source link

Release 1.3.4 break build with fuse #179

Closed freswa closed 10 months ago

freswa commented 10 months ago

Hey, Arch Linux maintainer here. I'm looking forward to see bcachefs in a stable kernel finally :) Unfortunately bcachefs-tools doesn't build anymore with tag 1.3.4.

Build cmd: BCACHEFS_FUSE=1 make

Log:

    [CC]     bcachefs.o
    [CC]     cmd_assemble.o
    [CC]     cmd_attr.o
    [CC]     cmd_data.o
    [CC]     cmd_device.o
    [CC]     cmd_dump.o
    [CC]     cmd_format.o
    [CC]     cmd_fs.o
    [CC]     cmd_fsck.o
    [CC]     cmd_fusemount.o
cmd_fusemount.c: In function ‘bcachefs_fuse_setattr’:
cmd_fusemount.c:209:35: error: ‘BTREE_INSERT_NOFAIL’ undeclared (first use in this function)
  209 |                                   BTREE_INSERT_NOFAIL);
      |                                   ^~~~~~~~~~~~~~~~~~~
cmd_fusemount.c:209:35: note: each undeclared identifier is reported only once for each function it appears in
In file included from libbcachefs/str_hash.h:6,
                 from libbcachefs/dirent.h:5,
                 from cmd_fusemount.c:19:
cmd_fusemount.c: In function ‘bcachefs_fuse_unlink’:
cmd_fusemount.c:289:48: error: ‘BTREE_INSERT_NOFAIL’ undeclared (first use in this function)
  289 |         int ret = bch2_trans_do(c, NULL, NULL, BTREE_INSERT_NOFAIL,
      |                                                ^~~~~~~~~~~~~~~~~~~
libbcachefs/btree_update.h:142:21: note: in definition of macro ‘bch2_trans_run’
  142 |         int _ret = (_do);                                               \
      |                     ^~~
libbcachefs/btree_update.h:132:9: note: in expansion of macro ‘lockrestart_do’
  132 |         lockrestart_do(_trans, _do ?: bch2_trans_commit(_trans, (_disk_res),\
      |         ^~~~~~~~~~~~~~
libbcachefs/btree_update.h:148:28: note: in expansion of macro ‘commit_do’
  148 |         bch2_trans_run(_c, commit_do(trans, _disk_res, _journal_seq, _flags, _do))
      |                            ^~~~~~~~~
cmd_fusemount.c:289:19: note: in expansion of macro ‘bch2_trans_do’
  289 |         int ret = bch2_trans_do(c, NULL, NULL, BTREE_INSERT_NOFAIL,
      |                   ^~~~~~~~~~~~~
cmd_fusemount.c: In function ‘inode_update_times’:
cmd_fusemount.c:541:33: error: ‘BTREE_INSERT_NOFAIL’ undeclared (first use in this function)
  541 |                                 BTREE_INSERT_NOFAIL);
      |                                 ^~~~~~~~~~~~~~~~~~~
make: *** [Makefile:114: cmd_fusemount.o] Error 1
koverstreet commented 10 months ago

Hey! Thanks for your work :)

Fuse support is definitely not ready, so please don't include it in distro packages yet - it's only there for the people working on it.