search

koverstreet / bcachefs-tools

http://bcachefs.org
GNU General Public License v2.0
120 stars 89 forks source link

rust: remove dependency on itertools #205

Closed paravoid closed 8 months ago

paravoid commented 8 months ago

The only use for itertools is in parse_mount_options() where we take a vector, convert it to iterator and then join it. Instead, we can join the vector directly.

Note: I'm really a beginner in Rust. Please review closely.

koverstreet commented 8 months ago

Single pull request in a single branch please, this is too much clicking around :)

paravoid commented 8 months ago

I split them up because I'm really not sure about any of them and wanted a case-by-case review. But I'll keep it in mind for future PRs. Could you merge this round of PRs in the meantime? Thanks!

koverstreet commented 8 months ago

This has been merged