search

koverstreet / bcachefs-tools

http://bcachefs.org
GNU General Public License v2.0
120 stars 89 forks source link

`bcachefs format` device specific options are inherited by later devices #226

Open freswa opened 7 months ago

freswa commented 7 months ago

bcachefs format --label hdd.hdd0 /dev/mapper/hdd0 --label=ssd.ssd0 --discard --durability=2 /dev/mapper/ssd0

Gives me hdd0 with durability 1 and discard disabled.

bcachefs format --label=ssd.ssd0 --discard --durability=2 /dev/mapper/ssd0 --label hdd.hdd0 /dev/mapper/hdd0

Gives me hdd0 with durability 2 and discard enabled.

If intentional, we need to document this behavior.

daurnimator commented 7 months ago

Looks like dev_opts is not completely reset in https://github.com/koverstreet/bcachefs-tools/blob/78e75113f7774a03e3c261f51acedfe34d30e09f/c_src/cmd_format.c#L211 I think it should be replaced with 

    dev_opts = dev_opts_default();