search

koverstreet / bcachefs-tools

http://bcachefs.org
GNU General Public License v2.0
116 stars 88 forks source link

Attempting to unlock encrypted partitions results in 100% CPU usage and partition never being unlocked #265

Closed Valmar33 closed 3 months ago

Valmar33 commented 3 months ago

First bad commit is https://github.com/koverstreet/bcachefs-tools/commit/477670f48167cac1b871b061713cc1b594a2a941

With this commit, attempting to unlock a partition results in the process consuming 100% CPU and never actually getting to unlocking the partition. Rather it just stalls forever. Though the process can be cleanly stopped with Ctrl+C.

tmuehlbacher commented 3 months ago

This looks like it would be fixed by the second commit in #263

Valmar33 commented 3 months ago

This looks like it would be fixed by the second commit in #263

I've tested the MR and it appears to work. Do I close this issue?

tmuehlbacher commented 3 months ago

I think that would be fine. I hope to get the fixes merged soon. Thanks for testing and also for bisecting all the way in the first place. 🙂

Valmar33 commented 3 months ago

I think that would be fine. I hope to get the fixes merged soon. Thanks for testing and also for bisecting all the way in the first place. 🙂

It is much easier when it's a userspace tool that doesn't require a bigger series of steps like rebooting and trying to trigger something, heh.

JohnRTitor commented 3 months ago

I don't think it should be closed since the patch has not been merged yet. "Closing this as completed" kind of signifies that the bug has been fixed already and the fix is in master, which is not the case here.