search

koverstreet / bcachefs

Other
687 stars 71 forks source link

umount returns 0 but fs is still mounted [85619448f54e] #492

Open marcin-github opened 1 year ago

marcin-github commented 1 year ago

Probably this could be somehow related to bug #491 but I saw similar behavior in past. Description is short:

 # umount /dane/media  ; echo er: $?
er: 0

but in dmesg there is no information about umounting fs and message copygc requested to run but found no buckets to move! dev 0 fragmented 672 allowed 0 still is flooding dmesg.

mount shouldn't exit with error code zero if umount wasn't issued.

marcin-github commented 1 year ago

I observed that umount almost always doesn't do umount action when there is a lot of CPU and I/O (on other bcachefs filesystems on the host) pressure.

marcin-github commented 10 months ago

I still observe that umount often doesn't do full umount. There is no files from fs but there is nomessages indmesg that was unmounted. Also fsck on block device says "recovering from unclean shutdown".

koverstreet commented 10 months ago

Do you know how to reproduce it?

If you mount with -o verbose, that gets us some extra logging in the unmount path - I'll add more.