koverstreet / bcachefs

Other
662 stars 70 forks source link

compiler warnings when compiling without quota support [patch included] [3215ae3] #582

Closed jpsollie closed 1 year ago

jpsollie commented 1 year ago

When compiling without quota support, fs-io.h is included a number of times with dummy functions, but sometimes even those are not used. this causes compiler warnings. a 'quick-and-easy' patch to fix this included below:

--- a/fs/bcachefs/fs-io.h
+++ b/fs/bcachefs/fs-io.h
@@ -108,15 +108,15 @@ static inline int bch2_quota_reservation_add(struct bch_fs *c,

 #else

-static void __bch2_quota_reservation_put(struct bch_fs *c,
+static void __maybe_unused __bch2_quota_reservation_put(struct bch_fs *c,
                                         struct bch_inode_info *inode,
                                         struct quota_res *res) {}

-static void bch2_quota_reservation_put(struct bch_fs *c,
+static void __maybe_unused bch2_quota_reservation_put(struct bch_fs *c,
                                       struct bch_inode_info *inode,
                                       struct quota_res *res) {}

-static int bch2_quota_reservation_add(struct bch_fs *c,
+static int __maybe_unused bch2_quota_reservation_add(struct bch_fs *c,
                                      struct bch_inode_info *inode,
                                      struct quota_res *res,
                                      unsigned sectors,
koverstreet commented 1 year ago

These needed inline - fixed in the testing branch now