kovetskiy / mark

Sync your markdown files with Confluence pages.
https://samizdat.dev
Apache License 2.0
1.03k stars 156 forks source link

Simple block quotes are no longer rendered properly in confluence with 8.6 #247

Closed danielloganking closed 1 year ago

danielloganking commented 1 year ago

Bug

Version Affected: 8.6 Does this exist in previous versions? No

Steps to Reproduce

  1. Create the following markdown doc:
    
    # Test Doc for Blockquotes

Simple Blockquote

This paragraph is a simple blockquote


2. Publish the doc

Expected Result: Blockquote appears in <blockquote> HTML node Actual Result: Blockquote renders as an error box with the text 📜Unknown Macro: 'none'

Background

I am still in the process of debugging what exactly is occurring but, following an upgrade to 8.6, when publishing to confluence we now see an error box in any place in the document which uses "simple" blockquotes (ie > some blockquote). Downgrading to 8.5 resolved the issue and blockquotes returned to their normal appearance.

Assuming I do not get pulled in to other work my plan is to create some tesk markdown and compare the HTML output of 8.5 to 8.6 and dig into the code to understand why this regression occurred.

mrueg commented 1 year ago

The recent change on blockquotes I see is: https://github.com/kovetskiy/mark/commit/8c02497b5f192286eea4f51130a2a4a134c72966

Do multi-line block quotes still work?

@prokod are you able to help with this one?

prokod commented 1 year ago

Hi @mrueg @danielloganking

  1. This is a case I have not tested on the original PR
  2. I have created new PR #248 that should address that case, namely blockquote with no box type hint on doc root level
  3. I have added this example to the quotes test
  4. I have added also some a small section in README.md to walk users through the changes in the tool behavior on that front

I hope it is addressing this issue correctly

danielloganking commented 1 year ago

Thank you for the quick fix🎉 I will test this on our doc where this was discovered later today.