search

kovetskiy / mark

Sync your markdown files with Confluence pages.
https://samizdat.dev
Other
988 stars 147 forks source link

Fix Attachment Recording in New Renderers #357

Closed nyarly closed 11 months ago

nyarly commented 11 months ago

During the process of migrating to individual sub-renderers, it looks like the process of adding attachments got broken.

The initial version of the code broke out using the ConfluenceExtension Attachments slice in a way analogous to: https://go.dev/play/p/oA91ElVhL8i One of Go's fun gotchas!

Closes #356

mrueg commented 11 months ago

Thanks for fixing this! This branch cannot be rebased due to conflicts Can you rebase it on latest master branch?

mrueg commented 11 months ago

Thanks!