Bugfix/tablealignment - Githubissues

kovetskiy / mark

Sync your markdown files with Confluence pages.

https://samizdat.dev

Other

988 stars 147 forks source link

Bugfix/tablealignment #360

Closed Skeeve closed 10 months ago

Skeeve commented 11 months ago

Fixes the table alignment issues by adding some CSS to every page.

mrueg commented 10 months ago

From a first glance, the API doesn't seem to be the right place for those changes.

Skeeve commented 10 months ago

From a first glance, the API doesn't seem to be the right place for those changes.

Can you please elaborate?

Maybe there is a better place for that CSS?

mrueg commented 10 months ago

The appropriate place, if this alignment is not properly supported by https://github.com/yuin/goldmark's table extension would be

The table extension from goldmark itself
A customization of the extension in the renderer https://github.com/kovetskiy/mark/tree/master/pkg/mark/renderer

Skeeve commented 10 months ago

goldmark you cannot change, as it is following XHTML standards, as stated in their repository. So the align-attribute is correct there. But it violates HTML5.

For the renderer, t.b.h. I have no clue yet how to do it.

mrueg commented 10 months ago

Replaced by #376