kovetskiy / mark

Sync your markdown files with Confluence pages.
https://samizdat.dev
Other
972 stars 143 forks source link

Images in tables not uploaded when width is set #365

Open mrroach-ptv opened 9 months ago

mrroach-ptv commented 9 months ago

What happened?

Using the macro described in the README, and markdown that looks like:

| Overview |
| :------: |
| ![Overview](images/overview.png)<!-- width=1000 -->  |

The proper confluence markup is rendered:

      <tbody>
        <tr>
          <td align="center">
            <ac:image ac:alt="Overview"
              ><ri:attachment ri:filename="images_overview.png" ri:version-at-save="1"
            /></ac:image>
          </td>
        </tr>
      </tbody>

but the image is not uploaded as an attachment.

What did you expect to happen?

Image to be detected as an attachment.

How can we reproduce the behavior you experienced?

I think the above is repeatable and fairly minimal, happy to give more info if needed.

Information (please complete the following information):

Additional context If I try to force the attachment, by adding it explicitly:

<!-- Attachment: images/overview.png -->

I get this message:

WARN  unused attachment: images/overview.png

but the image displays appropriately

gthieleb commented 6 months ago

Is this bug related to the restriction mentioned in the README?