search

kovetskiy / mark

Sync your markdown files with Confluence pages.
https://samizdat.dev
Other
978 stars 143 forks source link

change: Drop XHTML #376

Closed mrueg closed 9 months ago

mrueg commented 9 months ago

Use HTML5 rendering instead

This should solve #360 by creating style attributes. https://github.com/yuin/goldmark/blob/master/extension/table.go#L502

@Skeeve

Skeeve commented 9 months ago

Will test.

Skeeve commented 9 months ago

Doesn't solve the issue.

When compiling this md:

# None

|HEADER1|HEADER2|
|:---:|---:|
|row1|row2|

This is generated:

2023-10-17 22:37:02.990 INFO  the leading H1 heading will be excluded from the Confluence output
<table>
<thead>
<tr>
<th align="center">HEADER1</th>
<th align="right">HEADER2</th>
</tr>
</thead>
<tbody>
<tr>
<td align="center">row1</td>
<td align="right">row2</td>
</tr>
</tbody>
</table>

As you can see: The deprecated "align" attribute is still present. It should be either "text-align" or we use CSS to align properly.

BTW: I don't think the headers should be aligned the same as the columns, but that's my personal preference.

mrueg commented 9 months ago

Maybe you tested with a different binary? I've added some tests for aligned tables and they use the style attribute.

Skeeve commented 9 months ago

Maybe I did something wrong, but I thought I checked out mrueg:drop-xhtml

Anyhow: Upon a new test, it worked as described.