kovetskiy / mark

Sync your markdown files with Confluence pages.
https://samizdat.dev
Other
977 stars 143 forks source link

iFrame allowfullscreen #404

Open richardjennings opened 6 months ago

richardjennings commented 6 months ago

Is your feature request related to a problem? Please describe. I would like to be able to publish an iframe with an embedded diagram that includes the full screen button on Confluence Cloud.

Describe the solution you'd like I would like to extend the iFrame template to include the allowfullscreen property

Describe alternatives you've considered Not having the fullscreen option - this is sub-optimal.

Additional context I have made an API request to confluence after manually setting the allowfullscreen option in Confluence Cloud and observed the property returned as <ac:parameter ac:name=\"allowfullscreen\">true</ac:parameter> . I believe I could contribute a PR implementing this change if it is likely to be accepted. Cheers