setup.py assumes MSVC on Windows

kovidgoyal / html5-parser

Fast C based HTML 5 parsing for python

Apache License 2.0

678 stars 33 forks source link

Open us88 opened 2 years ago

us88 commented 2 years ago

We'd like to use MinGW on Windows to compile this library, though line 22 is appending "/O2" explicitly:

cargs = ('/O2' if iswindows else '-O3').split()

There should probably be something in place to detect if someone is using Microsoft's Compiler or Clang or GCC

kovidgoyal commented 2 years ago

You are welcome to send a patch for it, I never use non-native compilers for platforms that have native compilers.