search

kovidgoyal / kitty

Cross-platform, fast, feature-rich, GPU based terminal
https://sw.kovidgoyal.net/kitty/
GNU General Public License v3.0
24.15k stars 972 forks source link

artifacts between terminal content and padding/margin space #2079

Closed absolutelynothelix closed 4 years ago

absolutelynothelix commented 4 years ago

hello, i've noticed some artifacts to appear between terminal content and padding/margin space if you display an image (kitty +kitten icat ..., originally found while playing with neofetch --kitty ...).

this issue seems to be related to background opacity, because if background is fully opaque, i can't reproduce the issue. this issue also seems to be related to window geometry, because i can reproduce it only with specific window sizes.

displaying an image with kitty +kitten icat ... then opening and closing nano, window_padding_width 12.0, background_opacity 0.8: 1571604674 displaying an image with kitty +kitten icat ... then opening and closing nano, window_padding_width 12.0, background_opacity 1.0: 1571604972

kitty config: https://hastebin.com/raw/tenageyoqe

kitty 0.14.6 compton v.7.4 both from arch linux repositories (not aur)

absolutelynothelix commented 4 years ago

i've also noticed that during some transitions (such as window resizing) margin/padding space has either different opacity, or different color, but i guess it could be compton issue. should i create another issue here to sort it out?

absolutelynothelix commented 4 years ago

initially i thought there are only vertical lines, but as you can see there is a kind of frame around the image. according to the xwininfo, the window size is 1014x911 (1010x907 w/o borders, i guess they are included) and the image size is 1400x1273. window padding is set to 12 and background opacity to 0.8. i hope you will be able to reproduce the issue with this information 123

Luflosi commented 4 years ago

@mighty9245 can you try compiling kitty from source with the patch from #2214 applied and see if that fixes your issue?

absolutelynothelix commented 4 years ago

@Luflosi, nah, the issue is still here. i would recommend you to play with terminal window geometry (resizing it and running the test) and you'll probably see that the issue is still here even with your patch.

btw i was playing with these lines adding -1 and +1 a while ago with no luck.