kovidgoyal / kitty

Cross-platform, fast, feature-rich, GPU based terminal
https://sw.kovidgoyal.net/kitty/
GNU General Public License v3.0
24.12k stars 972 forks source link

`hide_window_decorations titlebar_only` breaks when entering fullscreen (macos) #6009

Closed Spo0on closed 1 year ago

Spo0on commented 1 year ago

Describe the bug The hide_window_decorations titlebar-only works well when in non-fullscreen mode: the native titlebar and window controls on native titlebar disappears, the corners are round. But once i enter in fullscreen mode and then back to window mode the window controls of native titlebar reappear. That's annoying because they cover the actual content of window

To Reproduce Steps to reproduce the behavior:

  1. Set the hide_window_decorations to titlebar_only
  2. Open a terminal window
  3. Enter native fullscreen mode (cmd+ctrl - f)
  4. Exit native fullscreen mode
  5. See error (native window controls on top left corner)

Screenshots screenshot

Environment details

kitty 0.27.1 () created by Kovid Goyal
Darwin MacBook-Pro.station 22.2.0 Darwin Kernel Version 22.2.0: Fri Nov 11 02:08:47 PST 2022; root:xnu-8792.61.2~4/RELEASE_X86_64 x86_64
ProductName:        macOS ProductVersion:       13.1 BuildVersion:      22C65
Frozen: True
Paths:
  kitty: /Applications/kitty.app/Contents/MacOS/kitty
  base dir: /Applications/kitty.app/Contents/Resources/kitty
  extensions dir: /Applications/kitty.app/Contents/Resources/Python/lib/kitty-extensions
  system shell: /bin/zsh
Loaded config files:
  /Users/giuliocorona/.config/kitty/kitty.conf

Config options different from defaults:
background_opacity           0.99
bold_font                    JetBrains Mono
bold_italic_font             JetBrains Mono
dynamic_background_opacity   True
enable_audio_bell            False
font_family                  JetBrains Mono
font_size                    15.0
hide_window_decorations      2
initial_window_height        (480, 'px')
input_delay                  20
italic_font                  JetBrains Mono
macos_thicken_font           0.1
macos_traditional_fullscreen True
tab_activity_symbol          󰪥 
tab_bar_edge                 1
tab_bar_margin_height        TabBarMarginHeight(outer=4.0, inner=4.0)
tab_bar_margin_width         1.0
tab_bar_style                custom
tab_powerline_style          round
tab_separator                
Added shortcuts:
    cmd+d →  new_window_with_cwd
    cmd+u →  set_background_opacity +0.01
    ctrl+cmd+h →  resize_window narrower
    ctrl+cmd+j →  resize_window taller
    ctrl+cmd+k →  resize_window shorter
    ctrl+cmd+l →  resize_window wider
    ctrl+cmd+u →  set_background_opacity -0.01
    ctrl+shift+cmd+h →  move_window left
    ctrl+shift+cmd+j →  move_window down
    ctrl+shift+cmd+k →  move_window up
    ctrl+shift+cmd+l →  move_window right
    kitty_mod+' →  move_window_to_top
    kitty_mod+a →  launch --location=vsplit --cwd=current
    opt+cmd+j →  neighboring_window down
    opt+cmd+k →  neighboring_window up
    opt+cmd+l →  neighboring_window right
    opt+cmd+m →  toggle_layout stack
Removed shortcuts:
    kitty_mod+a > 1 →  set_background_opacity 1
    kitty_mod+a > d →  set_background_opacity default
    kitty_mod+a > l →  set_background_opacity -0.1
    kitty_mod+a > m →  set_background_opacity +0.1
Changed shortcuts:
    cmd++ →  change_font_size all +1.0
    cmd+- →  change_font_size all -1.0
    cmd+1 →  goto_tab 1
    cmd+2 →  goto_tab 2
    cmd+3 →  goto_tab 3
    cmd+4 →  goto_tab 4
    cmd+5 →  goto_tab 5
    cmd+6 →  goto_tab 6
    cmd+7 →  goto_tab 7
    cmd+8 →  goto_tab 8
    cmd+9 →  goto_tab 9
    cmd+n →  new_os_window_with_cwd
    cmd+t →  new_tab_with_cwd
    kitty_mod+s →  launch --location=hsplit --cwd=current
    kitty_mod+t →  new_tab_with_cwd
    opt+cmd+h →  neighboring_window left
Colors:
    active_border_color          #82aaff   
    active_tab_background        #82aaff   
    active_tab_foreground        #1e2030   
    background                   #222436   
    color0                       #1b1d2b   
    color1                       #ff757f   
    color10                      #c3e88d   
    color11                      #ffc777   
    color12                      #82aaff   
    color13                      #c099ff   
    color14                      #86e1fc   
    color15                      #c8d3f5   
    color16                      #ff966c   
    color17                      #c53b53   
    color2                       #c3e88d   
    color3                       #ffc777   
    color4                       #82aaff   
    color5                       #c099ff   
    color6                       #86e1fc   
    color7                       #828bb8   
    color8                       #444a73   
    color9                       #ff757f   
    cursor                       #c3e88d   
    cursor_text_color            #222436   
    foreground                   #c8d3f5   
    inactive_border_color        #2f334d   
    inactive_tab_background      #2f334d   
    inactive_tab_foreground      #545c7e   
    selection_background         #3654a7   
    selection_foreground         #c8d3f5   
    url_color                    #4fd6be   

Important environment variables seen by the kitty process:
    PATH                                /Applications/kitty.app/Contents/MacOS:/Users/giuliocorona/.cargo/bin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin
    LANG                                it_IT.UTF-8
    SHELL                               /bin/zsh
    USER                                giuliocorona

Additional context hide_window_decorations titlebar-only

Spo0on commented 1 year ago

EDIT: This happens only when the macos_traditional_fullscreenis set to yes.