kovidgoyal / kitty

Cross-platform, fast, feature-rich, GPU based terminal
https://sw.kovidgoyal.net/kitty/
GNU General Public License v3.0
24.16k stars 972 forks source link

Inconsistent `icat` behaviour between Kitty `v0.28.1` and `v0.29` #6474

Closed gsbabil closed 1 year ago

gsbabil commented 1 year ago

DESCRIBE THE BUG

TO REPRODUCE

  1. Start kitty
  2. Start tmux inside kitty
  3. Run the following test commands inside tmux:
tmux set -p allow-passthrough on

echo "* OS version:"
sw_vers
echo
echo "* Kitty version: $(kitty --version)"
echo
echo "TERM = ${TERM}"
echo "TERM_ROGRAM = ${TERM_PROGRAM}"
echo "TERM_ROGRAM_VERSION = ${TERM_PROGRAM_VERSION}"
echo "TERMINFO = ${TERMINFO}"
echo
curl -sL https://github.com/hzeller/timg/assets/1061108/53ca87bd-53fd-484c-aad4-f5b56b22b3cb > bender.jpg
icat bender.jpg

SCREENSHOTS

Kitty v0.29 + Tmux v3.3a

image

Kitty v0.28.1 + Tmux v3.3a

image

ENVIRONMENT DETAILS

Kitty v0.29 + Tmux v3.3a

kitty 0.29.0 (e2b5c6688d) created by Kovid Goyal
Darwin iMac.local 22.5.0 Darwin Kernel Version 22.5.0: Thu Jun  8 22:22:22 PDT 2023; root:xnu-8796.121.3~7/RELEASE_X86_64 x86_64
ProductName:        macOS ProductVersion:       13.4.1 ProductVersionExtra: (c) BuildVersion:       22F770820d
Frozen: True
Paths:
  kitty: /Applications/kitty.app/Contents/MacOS/kitty
  base dir: /Applications/kitty.app/Contents/Resources/kitty
  extensions dir: /Applications/kitty.app/Contents/Resources/Python/lib/kitty-extensions
  system shell: /bin/zsh
Loaded config files:
  /Users/babil/.config/kitty/kitty.conf

Config options different from defaults:
enable_audio_bell    False
font_family          FiraCode Nerd Font
font_size            14.65
kitty_mod            shift+cmd
macos_thicken_font   0.75
scrollback_lines     20000
window_border_width  (2.0, 'pt')
window_margin_width  FloatEdges(left=1.0, top=1.0, right=1.0, bottom=1.0)
Removed shortcuts:
    shift+cmd+- →  change_font_size all -2.0
    shift+cmd+= →  change_font_size all +2.0
    shift+cmd+[ →  previous_tab
    shift+cmd+] →  next_tab
    shift+cmd+w →  close_os_window
Changed shortcuts:
    kitty_mod+[ →  previous_tab
    kitty_mod+] →  next_tab
    kitty_mod+w →  close_os_window
Colors:
    active_border_color  #ff00ff   
    background           #1e1e1e   
    color0               #3a3c43   
    color1               #be3e48   
    color10              #0e712e   
    color11              #c37033   
    color12              #176ce3   
    color13              #fb0067   
    color14              #2d6f6c   
    color15              #fcffb8   
    color2               #869a3a   
    color3               #c4a535   
    color4               #4e76a1   
    color5               #855b8d   
    color6               #568ea3   
    color7               #b8bcb9   
    color8               #888987   
    color9               #fb001e   
    cursor               #eeeeee   
    foreground           #b8bcb9   
    selection_background #efcc00   
    selection_foreground #1e1e1e   

Important environment variables seen by the kitty process:
    PATH                                /Applications/kitty.app/Contents/MacOS:/usr/bin:/bin:/usr/sbin:/sbin
    LANG                                en_AU.UTF-8
    SHELL                               /bin/zsh
    DISPLAY                             /private/tmp/com.apple.launchd.DtUADfZN85/org.xquartz:0
    USER                                babil

Kitty v0.28.1 + Tmux v3.3a

kitty 0.28.1 (07bcc5ba61) created by Kovid Goyal
Darwin iMac.local 22.5.0 Darwin Kernel Version 22.5.0: Thu Jun  8 22:22:22 PDT 2023; root:xnu-8796.121.3~7/RELEASE_X86_64 x86_64
ProductName:        macOS ProductVersion:       13.4.1 ProductVersionExtra: (c) BuildVersion:       22F770820d
Frozen: True
Paths:
  kitty: /Applications/kitty.app/Contents/MacOS/kitty
  base dir: /Applications/kitty.app/Contents/Resources/kitty
  extensions dir: /Applications/kitty.app/Contents/Resources/Python/lib/kitty-extensions
  system shell: /bin/zsh
Loaded config files:
  /Users/babil/.config/kitty/kitty.conf

Config options different from defaults:
enable_audio_bell    False
font_family          FiraCode Nerd Font
font_size            14.65
kitty_mod            shift+cmd
macos_thicken_font   0.75
scrollback_lines     20000
window_border_width  (2.0, 'pt')
window_margin_width  FloatEdges(left=1.0, top=1.0, right=1.0, bottom=1.0)
Removed shortcuts:
    shift+cmd+- →  change_font_size all -2.0
    shift+cmd+= →  change_font_size all +2.0
    shift+cmd+[ →  previous_tab
    shift+cmd+] →  next_tab
    shift+cmd+w →  close_os_window
Changed shortcuts:
    kitty_mod+[ →  previous_tab
    kitty_mod+] →  next_tab
    kitty_mod+w →  close_os_window
Colors:
    active_border_color  #ff00ff   
    background           #1e1e1e   
    color0               #3a3c43   
    color1               #be3e48   
    color10              #0e712e   
    color11              #c37033   
    color12              #176ce3   
    color13              #fb0067   
    color14              #2d6f6c   
    color15              #fcffb8   
    color2               #869a3a   
    color3               #c4a535   
    color4               #4e76a1   
    color5               #855b8d   
    color6               #568ea3   
    color7               #b8bcb9   
    color8               #888987   
    color9               #fb001e   
    cursor               #eeeeee   
    foreground           #b8bcb9   
    selection_background #efcc00   
    selection_foreground #1e1e1e   

Important environment variables seen by the kitty process:
    PATH                                /Applications/kitty.app/Contents/MacOS:/usr/bin:/bin:/usr/sbin:/sbin
    LANG                                en_AU.UTF-8
    SHELL                               /bin/zsh
    DISPLAY                             /private/tmp/com.apple.launchd.DtUADfZN85/org.xquartz:0
    USER                                babil

ADDITIONAL CONTEXT

image
kovidgoyal commented 1 year ago

dup of #6467

gsbabil commented 1 year ago

Hi @kovidgoyal, Thanks for the quick response.

6467 seems to involve scrolling, whereas this issue #6474, I think, only involves the --passthrough and --unicode-placeholder options in icat.

Is there any other reason why v0.28.1 and v0.29 are behaving inconsistently? Any other options we can set? For example, the correct image output is not produced in v0.29 even if I don't scroll.

There's also a brief mention of this "incorrect image output" issue here as well, although the focus continues to remain on the scrolling related bug.

Thank you.

kovidgoyal commented 1 year ago

Either wait for the next release or install kitty nightly and you will be fine.

BigBrotherJu commented 1 year ago

@gsbabil Nightly already fixed this unicode placeholder bug. Kudos to kovid!

gsbabil commented 1 year ago

@kovidgoyal @BigBrotherJu Wonderful! Thank you for Kitty!