kovidgoyal / kitty

Cross-platform, fast, feature-rich, GPU based terminal
https://sw.kovidgoyal.net/kitty/
GNU General Public License v3.0
24.83k stars 995 forks source link

Unicode favorites are now sorted by codepoint #6610

Closed remexre closed 1 year ago

remexre commented 1 year ago

Describe the bug

The favorites tab of the Unicode picker is now sorted by codepoint, rather than being in the order the user specified.

To Reproduce Steps to reproduce the behavior:

  1. Create a unicode-input-favorites.conf that contains code points that are not in codepoint order
  2. Press Ctrl-Shift-U, F4
  3. Note that the code points have been sorted

Screenshots

unicode-input-favorites.conf:

# Favorite characters for unicode input
# Enter the hex code for each favorite character on a new line. Blank lines are
# ignored and anything after a # is considered a comment.

# Subscript zero thru 9
2080
2081
2082
2083
2084
2085
2086
2087
2088
2089

# Subscript a thru z, with underscores replacing the characters not present
2090 #    a
005f # no b
005f # no c
005f # no d
2091 #    e
005f # no f
005f # no g
...

image

Environment details

kitty 0.28.1 created by Kovid Goyal
Linux f12 6.1.42 #1-NixOS SMP PREEMPT_DYNAMIC Thu Jul 27 06:50:53 UTC 2023 x86_64

<<< Welcome to NixOS 23.05.20230804.9652a97 (x86_64) - /dev/tty >>>

Run 'nixos-help' for the NixOS manual.

DISTRIB_CODENAME=stoat
DISTRIB_DESCRIPTION="NixOS 23.05 (Stoat)"
DISTRIB_ID=nixos
DISTRIB_RELEASE="23.05"
LSB_VERSION="23.05 (Stoat)"
Running under: Wayland
Frozen: False
Paths:
  kitty: /nix/store/6fvci206rnjcsdg6sq0wddhlk3q0g6xq-kitty-0.28.1/bin/kitty
  base dir: /nix/store/6fvci206rnjcsdg6sq0wddhlk3q0g6xq-kitty-0.28.1/lib/kitty
  extensions dir: /nix/store/6fvci206rnjcsdg6sq0wddhlk3q0g6xq-kitty-0.28.1/lib/kitty/kitty
  system shell: /run/current-system/sw/bin/zsh
Loaded config files:
  /home/nathan/.config/kitty/kitty.conf

Config options different from defaults:
font_family           Iosevka
font_size             12.0
initial_window_height (25, 'cells')
initial_window_width  (80, 'cells')
remember_window_size  False
Colors:
    color1                #cd0000   
    color10               #00ff00   
    color11               #ffff00   
    color12               #5c5cff   
    color13               #ff00ff   
    color14               #00ffff   
    color2                #00cd00   
    color3                #cdcd00   
    color4                #0000ee   
    color5                #cd00cd   
    color6                #00cdcd   
    color7                #e5e5e5   
    color8                #7f7f7f   
    color9                #ff0000   

Important environment variables seen by the kitty process:
    PATH                                /nix/store/6fvci206rnjcsdg6sq0wddhlk3q0g6xq-kitty-0.28.1/bin:/nix/store/97xl0ih2kbwfh36xlj99lw30v17qjzy7-imagemagick-7.1.1-15/bin:/nix/store/3j8n1hl92r8bhwzqxgvx3nzpb6h59qm2-ncurses-6.4-dev/bin:/run/wrappers/bin:/home/nathan/.nix-profile/bin:/etc/profiles/per-user/nathan/bin:/nix/var/nix/profiles/default/bin:/run/current-system/sw/bin:/home/nathan/.zsh/plugins/fast-syntax-highlighting
    LANG                                en_US.UTF-8
    EDITOR                              nvim
    SHELL                               /run/current-system/sw/bin/zsh
    DISPLAY                             :0
    WAYLAND_DISPLAY                     wayland-1
    USER                                nathan
    XCURSOR_SIZE                        24
    XDG_CONFIG_DIRS                     /etc/xdg:/home/nathan/.nix-profile/etc/xdg:/etc/profiles/per-user/nathan/etc/xdg:/nix/var/nix/profiles/default/etc/xdg:/run/current-system/sw/etc/xdg
    XDG_SEAT                            seat0
    XDG_SESSION_TYPE                    wayland
    XDG_CURRENT_DESKTOP                 sway
    XDG_SESSION_CLASS                   user
    XDG_DESKTOP_PORTAL_DIR              /nix/store/m0q71phrb04sfs0vy0qmp662srjmg17s-xdg-portals/share/xdg-desktop-portal/portals
    XDG_VTNR                            1
    XDG_SESSION_ID                      1
    XDG_RUNTIME_DIR                     /run/user/1000
    XDG_DATA_DIRS                       /nix/store/5hqsg7msznz75c7f8v020jg2ypyambsy-desktops/share:/home/nathan/.nix-profile/share:/etc/profiles/per-user/nathan/share:/nix/var/nix/profiles/default/share:/run/current-system/sw/share

Additional context

Try to reproduce the problem with kitty --config NONE if you cannot then post a minimal kitty.conf that reproduces the problem. If the problem involves interaction with some other terminal program post a minimal config for that program to reproduce the problem as well.

Reproduces.

kovidgoyal commented 1 year ago

dup of #6214