Closed dderjoel closed 6 months ago
This is a bug in the theme you are using. The highlight kitten does not use any actual colors, instead it makes use of only the first 16 indexed colors whose actual values are set by the theme. The theme is violating contrast requirements between those colors.
Use for instance Gruvbox Light or Kaolin Breeze and you will be fine.
Oh and in case you dont want to change the theme you can also use --hints-text-color when invoking the kitten to override the color.
Yes thanks for coming back this quick. I thought it could be a themes bug, but I tried a couple themes and all of them showed the same issue. Thanks! I'll use the two that work then :)
Should I open another issue for the fact that it parses the paths wrong when a file has spaces (V46 - Repaired - Repaired
)?
Spaces are not considered part of file paths, if they were it would become impossible to, for instance, get filenames from the output of ls. You can ofc ourse customize this however you like, see the docs of the kitten.
yeah I know I could use regex, but ls
already prints the filename in '
s, so I assumed that --type=path
recognises that.
No, there are many tools apart from ls that prints paths separated from normal text by spaces. Path detection has to be more general. If you are particularly using it with ls use hyperlink mode, that is fully robust.
I'm not sure if we're talking about the same thing.
I am using ls --hyperlink=auto --color=auto
and then ls
will list the files. If a filename has spaces in it, it surrounds the name with quotation marks '
. I can now use my mouse to click it and icat-open it, but I fail do see how I could select it with my keyboard only.
Press ctrl+shift+p>y
yes, that lets me select correctly, but I want to insert the item on the cmd line.
When I use kitten hints --type hyperlink --program -
I end up with the link (e.g. file://arch4/home/joel/Videos/V45%20-%20Repaired.mp4
) on my cmd line. I couldn't find a way to select the hyperlink but then only print the name in the documentation of the hints kitten?
The actions and selection of the hints kitten are completely customizable you can even write your own code to do whatever you want with them, see the kitten docs.
Describe the bug
When using the hints kitten, pressing CTRL+SHIFT+P>F, the files are highlighted. When using a light theme, the highlighted bright color is illegible. This does not happen with a dark theme
To Reproduce Steps to reproduce the behavior:
ls
in some directoryScreenshots
Environment details
Additional context Cannot be reproduced with a blank config, because a light theme must be selected