kovisoft / slimv

Official mirror of Slimv versions released on vim.org
454 stars 60 forks source link

Add g:slimv_fasl_directory controlling written location of FASL files #119

Closed Jach closed 2 years ago

Jach commented 2 years ago

Hi, the default behavior when compiling/compile-and-loading individual files of spitting .fasl files into my source directories next to the .lisp files has been bothering me for a long time so I finally tried doing something about it, let me know your thoughts on the approach when you can. Apologies for the first commit making an uglier full diff by removing trailing whitespace, let me know if you want me to rebase it away.

Since I noticed #14 I looked for other implementations of compile-file-for-emacs and it seems Scheme's version is the only one that removes the options rest param used by the Lisp version for passing the fasl-directory. I was able to build a version of mit-scheme to test with, but slimv's swank did not work out of the box forcing me to set g:scheme_builtin_swank=1, which did work. I rewrote an initial version of the Python changes that just passed the path or nil to now pass the whole keyword+path or nothing. mit-scheme will still hang if this parameter is set and the Compile File command is used, but it won't break if it's missing.

kovisoft commented 2 years ago

Thank you for the contribution, and sorry for the late response. I was quite busy this week.