kowainik / crocodealer

🐊 Manage GitHub organization files, labels, issues
https://kowainik.github.io/projects/crocodealer
Mozilla Public License 2.0
9 stars 4 forks source link

[#12] Add dry mode implementation of croco sync command #17

Closed Nimor111 closed 4 years ago

Nimor111 commented 4 years ago

Fixes #12

Tested in GHCI with the following line:

sync (UserName "kowainik") (RepoName "org") (FileName ".stylish-haskell.yaml") [(RepoName "tomland"), (RepoName "summoner")] 

Not really sure about the choice of http library, if you prefer another one i'm happy to check it out.

P.S. Sorry for the spam of commit messages in the issue, forgot I shouldn't put the issue number on format and style fixes. :/

Nimor111 commented 4 years ago

Not sure why build is failing :/

Nimor111 commented 4 years ago

I will do the switch to a more lightweight client in another PR, to keep the philosophy of one issue per PR. :)

chshersh commented 4 years ago

@Nimor111 I'm okay with replacing http-conduit with more lightweight libraries in a separate PR. I imagine it's easier to contribute smaller changes rather than big ones, but sometimes big changes like in this PR are necessary...