search

kowainik / crocodealer

🐊 Manage GitHub organization files, labels, issues
https://kowainik.github.io/projects/crocodealer
Mozilla Public License 2.0
9 stars 4 forks source link

[#3] Basic configuration types and label rules #7

Closed yaman closed 5 years ago

yaman commented 5 years ago

Basic data types for a simple configuration.

kahlil29 commented 5 years ago

Seems like the build is failing. Is it compiling fine on your local machine @yaman ?

yaman commented 5 years ago

@kahlil29 Yeap, it compiles fine.

yaman commented 5 years ago
  • Not sure whether we should be using String or Text. Of late, I have become biased towards Text unless some manipulations are required which would be better via Strings. @chshersh or @vrom911 would be able to confirm about this.

Sure, I would be happy to change it.

yaman commented 5 years ago

Build fails because; in Crocodealer/Config.hs, we have our types but since we do not use them yet, stack build with flag --ghc-options=-Werror brakes the build.

vrom911 commented 5 years ago

Hey @yaman, do you need any help with the comments here? Don't worry if you don't have time now, just let us know if we could help you :slightly_smiling_face:

yaman commented 5 years ago

I was just outside of the city last week. But I'm back and ready to fix according to feedbacks :blush: