kowainik / hit-on

:octocat: Kowainik Git Workflow Helper Tool
https://kowainik.github.io/projects/hit-on
Mozilla Public License 2.0
76 stars 13 forks source link

[#35] Implement Unit Tests for 'parseOwnerRepo' function #74

Closed kahlil29 closed 5 years ago

kahlil29 commented 5 years ago

Do let me know if anything needs to be changed/corrected/added 😄

kahlil29 commented 5 years ago

@chshersh Thanks for taking the time to review this PR in detail. Even though it's a small PR, there were quite a few things(formatting, etc) I missed out. Since I'm not used to raising PRs often in kowainik, I am not extremely familiar with the style guide and I hope that in my next PR, these errors would be less/not present 👍

I have made the requested changes and pushed them. CI seems to have passed successfully!

Do let me know if there's anything else to be done before it can be merged into master 😄