Closed TomMD closed 4 years ago
In addition, we should consider a flag or default of making the description
markdown or otherwise render-friendly. The current system seems to have the code inline with the issue text which makes highlighting hard.
- An observation description field with inspectionDescription contents.
- An observation name from inspectionName
This information is already present in JSON. We output the list of all inspections used in the code, so you can easily get these pieces of data. Changing ToJSON
instances for our types to add redundant information will complicate Stan design and prevent implementation of future features from our roadmap.
This information is already present in JSON.
Great, I didn't see that. Now we're down to getting spans in a JSON form (number 3).
One file entry of JSON output looks like so:
This is really rich, but I am hoping to get a few additional fields to make external tools' lives easier.
description
field withinspectionDescription
contents.name
frominspectionName
srcLocLine (realSrcSpanStart observationLoc)
.The first two are new information. It seems with the current information each consumer would need to have the mapping of inspectionId to inspection text in order to make use of the JSON.
The final one is indeed redundant, but if we're outputting JSON then making consumers parse another, non-standard, format doesn't fit the spirit of machine parsable.
Thoughts? Would a PR be acceptable.
Also huge thanks to @vrom911 for finding a threading of the needle that satisfies both competing asks from the prior ticket of JSON and low dependency overhead.