search

kowainik / stan

🕵️ Haskell STatic ANalyser
https://kowainik.github.io/projects/stan
Mozilla Public License 2.0
563 stars 48 forks source link

🤖 Suggest `Text` and `ByteString` instead of `String` #396

Closed kutyel closed 3 years ago

kutyel commented 3 years ago

Fixes #386, happy Hacktoberfest! 🚀

PS: sorry for the unrelated change of the hie.yaml, HSL didn't work in my local machine without this file

kutyel commented 3 years ago

Maybe the hacktoberfest-accepted label could be added to this PR? If it is not much to ask 😉

chshersh commented 3 years ago

@kutyel Done!

jfmengels commented 3 years ago

It's great that you give a solution in the reported error. That said, I don't know Haskell, but as a beginner I think I would be confused as to why String is considered an anti-pattern when reading the error report. I would advise to add a short explanation and/or a link to a longer explanation. What do you think?

Whether to choose Text or ByteString seems less confusing though :+1:

kutyel commented 3 years ago

Done, thanks for your reviews! ❤️