search

kowainik / stan

🕵️ Haskell STatic ANalyser
https://kowainik.github.io/projects/stan
Mozilla Public License 2.0
562 stars 48 forks source link

Bump `stack.yaml`, include in sdist file #520

Closed mpilgrem closed 8 months ago

mpilgrem commented 8 months ago

stack.yaml is bumped to GHC 9.4.7, the most recent version of GHC supported by the tool.

stack.yaml is incuded in the sdist file. This will help Stack users install the tool from Hackage.

(As an aside, the current stack.yaml file will not work because it does not set the flags required for its mintty dependency. That falls away if this pull request is adopted.)

tomjaguarpaw commented 8 months ago

Thanks! Any idea how to address this build failure?

https://github.com/kowainik/stan/actions/runs/6518739825/job/17704572148?pr=520

Maybe the version of stack in ci.yml needs to be bumped?

mpilgrem commented 8 months ago

Sorry, I had forgotten about the test-suite. Trying again.

tomjaguarpaw commented 8 months ago

I'm confused how this managed to pass given that it doesn't contain a change to ci.yml. Do you understand?

mpilgrem commented 8 months ago

@tomjaguarpaw, it was failing before because the test-suite (a) required hedgehog < 1.2 (while lts-21.15 specified hedgehog-1.2); and (b) hedgehog-1.1.2 required primitive < 0.8 (while lts-21.15 specified primitive-0.8.0.0. Downgrading those dependencies (as extra-deps) solved the problem.

tomjaguarpaw commented 8 months ago

OK, thanks. If you'd be willing to be the "owner" of stan's stack support then I would appreciate it. I have no idea about stack.

mpilgrem commented 8 months ago

I'm happy to keep a weather eye on building Stan with Stack. The Stack project was experimenting with using Stan as part of its CI, until Stack moved on to a version of GHC that Stan did not support. I'm currently looking at doing so again, as Stack is still built with GHC 9.4.7 (for now).

tomjaguarpaw commented 8 months ago

Great, feel free to ping me if you need help with stan support for any Stack version. 9.6 support is imminent.