search

kowainik / stan

🕵️ Haskell STatic ANalyser
https://kowainik.github.io/projects/stan
Mozilla Public License 2.0
562 stars 48 forks source link

Better interface #551

Closed 0rphee closed 6 months ago

0rphee commented 6 months ago

The hls-stan-plugin, lacked the capability to take into account .stan.toml files. While I've managed to make it work by roughly replicating what runStan does in the Stan module, it was recommended to add a more packaged solution to stan itself, and rely on those functions instead.

The primary goal of this would be to break up runStan into various functions that can be used by hls. At this moment I'm trying out how that would look like and hopefully submit a PR, but if you have any recommendations, they are of course very welcome!

Here it's the relevant PR from hls, to get a better overview of what this would help with. https://github.com/haskell/haskell-language-server/pull/3914

tomjaguarpaw commented 6 months ago

Is this issue completed by https://github.com/kowainik/stan/pull/552, or is there more to it?

0rphee commented 6 months ago

I think its fine to close it.