search

kowainik / summoner

🔮 🔧 Tool for scaffolding batteries-included production-level Haskell projects
https://kowainik.github.io/projects/summoner
Mozilla Public License 2.0
694 stars 73 forks source link

Replace hub with gh #542

Closed DavSanchez closed 1 year ago

DavSanchez commented 3 years ago

Hi guys!

I have modified Summoner so it uses the official gh CLI application from GitHub instead of hub, which was already having problems with authorization (see https://github.com/github/hub/issues/2655#issue-752529775).

I have tested the behavior and works properly, creating public and private repositories on GitHub, and also run cabal test all. Strangely, Travis CI is failing on my repo due to code in other files that I have not modified, though here it seems that it's passing properly. I don't know what could be the cause 😟

Let me know what you think.

Regards, David

vrom911 commented 3 years ago

Hey @DavSanchez,

Thanks for your ideas. I haven't looked into code yet, as I would like to discuss the idea first. This sounds like a huge change. I am still using hub without any issues, so I do not have plans on moving to gh any time soon due to the lack of necessity. Also, all my tools are tight around hub, so I do not have an urge to move everything to something new.

I also want to highlight that we have not received any issue reports due to the hub usage. Note that we also suggest using ssh when working with GitHub, so this may resolve your issue.

Anyway, I would like to discuss this idea first before rushing into implementing this big change. Could you please elaborate more on the issue that you are encountering?

DavSanchez commented 3 years ago

Hi @vrom911,

Thanks for your answer. Yes I suppose this can be a pretty major change, I propose it because I stumbled upon this issue while trying to create a project with summoner and creating the remote repo at GitHub using HTTPS, and found it was not working unless I created a personal access token and used that instead of the password. It's not an issue with summoner per se, but with hub using a deprecated API. I suppose using SSH could allow to skip the linked issue, but since apparently gh is also being promoted as a more 'official' CLI for interacting with GitHub, I though it would be a good idea to use it with summoner too.

Of course this is just a proposal, if you think hub is preferable to gh please feel free to close the PR or leave it by for a future time (for example, if hub stops to be maintained for whatever reason then this could be reconsidered).

Best regards, David