search

kowainik / summoner

🔮 🔧 Tool for scaffolding batteries-included production-level Haskell projects
https://kowainik.github.io/projects/summoner
Mozilla Public License 2.0
698 stars 73 forks source link

Support GHC 8.10.7 #547

Closed chshersh closed 3 years ago

chshersh commented 3 years ago

It's out and contains several bugfixes:

But Stackage doesn't support it at the moment.

piq9117 commented 3 years ago

I got curious and tried building the project with ghc-8.10.6.

Ran it in a nix shell with this config

let
  pkgs = import (builtins.fetchGit {
    name = "nixpkgs-unstable";
    url = "https://github.com/nixos/nixpkgs.git";
    rev = "8c8cf04de23f2d79c02ce6ddadb71ddc6490ab7f";
  }){};
in
pkgs.mkShell {
  buildInputs = [
    pkgs.haskellPackages.ghc
    pkgs.haskellPackages.cabal-install
  ];
}

cabal version in this branch is 3.4.0.0. It built smoothly.

cabal build all and cabal test all all ran with success.

chshersh commented 3 years ago

Well, GHC 8.10.7 is already available, so I guess we're skipping 8.10.6

@piq9117 Thanks for confirming this! Usually, I don't expect compilation failures when upgrading from one minor GHC version to another. I see them only in huge very specific projects. And Summoner is not one of them 🙂

Also, this issue is not only about building Summoner itself with GHC 8.10.7. But also teaching Summoner to generate projects with the support for a newer GHC. And this requires slightly more work... A recent example of such version upgrade can be found here: