Closed noughtmare closed 1 month ago
@willbasky I've implemented your suggestion, thanks.
@vrom911 can you please review this?
@noughtmare The tests need the updates.
I've used gg
to update the golden tests.
What a nice tool!
It seems the CI also needed updating.
Oh, of course summoner itself doesn't build on 9.6.2
And that's blocked on shellmet, at least.
Warning: Unknown/unsupported 'ghc' version detected (Cabal 3.6.2.0 supports 'ghc' version < 9.4): /home/runner/.ghcup/bin/ghc is version 9.6.2
< 9.4 yes, building summoner with 9.4.5 and 9.6.2 has no ways right now.
Also, instead of 9.2.4
we could build on 9.2.8
But if we can't build on 9.4.5 and 9.6.2 then we also can't test if summoning those versions work, except perhaps if we would build summoner with a different version of GHC than what we use to test the summoned project.
Do the golden tests check if the 'project that is made with specific ghc in configs' is built with that ghc? In other words:
I think you're right that the tests only check things like 1, but then I don't understand why it did not work before I changed the CI. I'll revert that and we can try again.
Neat, the old results are still here.
Ah, so it's actually a separate CI action that tries to build the minimal project.
If checks within 9.6.2
will pass then we could left checks for 9.4.5
too
I've now added 9.4.5 too
Now it should work...
I've squashed the commits
@willbasky there will be a 9.4.7 soon, so I think we should skip 9.4.6.
Hi, GHC 9.4.7 is now available, and slated to be the final release of the 9.4 series. Anything blocking this from merging?
@kowainik @vrom911 @noughtmare @willbasky What is the plan to proceed with this PR to enable summoner to support GHC 9.2, 9.4, and 9.6? GHC 9.4.7 has been released, together with a new release 9.6.3.
A new version of summoner
on Hackage would also be much appreciated, as it's needed for the Arch package
@Vekhir I think this package has been abandoned. I'm personally not motivated enough to fork and initiate the package takeover process. So I think not much is going to change any time soon.
Alright, thanks for your reply.
@Vekhir Hi, I tried to message to @vrom911 in social media she didn't answer. As for me I haven't the right to merge here anything without second approval I guess. I am sorry.
I've rebased and changed 9.4.5 to 9.4.8 and 9.6.2 to 9.6.6 with the latest stackage lts.
Oh, now the golden tests have changed again
Now it might work. There are still two things that could be updated:
summoner-cli
and summoner-tui
themselvesCool, thanks! If you feel like making the other updates then please do, but for things like tested-with I find them too difficult to keep up to date if they're not checked by tooling.
Feel free to create another PR with the updates above.
@noughtmare @willbasky @Vekhir thanks for pushing this through!
@tomjaguarpaw Thanks for merging! Quick question: Do you also have the permissions to push Hackage releases? That would be quite useful in combination with this PR.
I've asked Veronika and she says she can give me Hackage permissions in a couple of weeks.
Alright.
I've also updated the latest Stackage snapshots of 8.10.7 and 9.0.2.