kowainik / summoner

🔮 🔧 Tool for scaffolding batteries-included production-level Haskell projects
https://kowainik.github.io/projects/summoner
Mozilla Public License 2.0
698 stars 73 forks source link

Add support for summoning GHC 9.2.8, 9.4.8, and 9.6.6 #570

Closed noughtmare closed 1 month ago

noughtmare commented 1 year ago

I've also updated the latest Stackage snapshots of 8.10.7 and 9.0.2.

noughtmare commented 1 year ago

@willbasky I've implemented your suggestion, thanks.

@vrom911 can you please review this?

willbasky commented 1 year ago

@noughtmare The tests need the updates.

noughtmare commented 1 year ago

I've used gg to update the golden tests.

willbasky commented 1 year ago

What a nice tool!

noughtmare commented 1 year ago

It seems the CI also needed updating.

noughtmare commented 1 year ago

Oh, of course summoner itself doesn't build on 9.6.2

noughtmare commented 1 year ago

And that's blocked on shellmet, at least.

willbasky commented 1 year ago

Warning: Unknown/unsupported 'ghc' version detected (Cabal 3.6.2.0 supports 'ghc' version < 9.4): /home/runner/.ghcup/bin/ghc is version 9.6.2

< 9.4 yes, building summoner with 9.4.5 and 9.6.2 has no ways right now.

Also, instead of 9.2.4 we could build on 9.2.8

noughtmare commented 1 year ago

But if we can't build on 9.4.5 and 9.6.2 then we also can't test if summoning those versions work, except perhaps if we would build summoner with a different version of GHC than what we use to test the summoned project.

willbasky commented 1 year ago

Do the golden tests check if the 'project that is made with specific ghc in configs' is built with that ghc? In other words:

  1. Summoner makes project with ghc version X.
  2. Tests tried to build made project. Is it?
noughtmare commented 1 year ago

I think you're right that the tests only check things like 1, but then I don't understand why it did not work before I changed the CI. I'll revert that and we can try again.

noughtmare commented 1 year ago

Neat, the old results are still here.

Ah, so it's actually a separate CI action that tries to build the minimal project.

willbasky commented 1 year ago

If checks within 9.6.2 will pass then we could left checks for 9.4.5 too

noughtmare commented 1 year ago

I've now added 9.4.5 too

noughtmare commented 1 year ago

Now it should work...

noughtmare commented 1 year ago

I've squashed the commits

willbasky commented 1 year ago

https://discourse.haskell.org/t/ghc-9-4-6-is-now-available/7231 I am sorry :))

noughtmare commented 1 year ago

@willbasky there will be a 9.4.7 soon, so I think we should skip 9.4.6.

Vekhir commented 1 year ago

Hi, GHC 9.4.7 is now available, and slated to be the final release of the 9.4 series. Anything blocking this from merging?

Vekhir commented 1 year ago

@kowainik @vrom911 @noughtmare @willbasky What is the plan to proceed with this PR to enable summoner to support GHC 9.2, 9.4, and 9.6? GHC 9.4.7 has been released, together with a new release 9.6.3.

A new version of summoner on Hackage would also be much appreciated, as it's needed for the Arch package

noughtmare commented 1 year ago

@Vekhir I think this package has been abandoned. I'm personally not motivated enough to fork and initiate the package takeover process. So I think not much is going to change any time soon.

Vekhir commented 1 year ago

Alright, thanks for your reply.

willbasky commented 1 year ago

@Vekhir Hi, I tried to message to @vrom911 in social media she didn't answer. As for me I haven't the right to merge here anything without second approval I guess. I am sorry.

noughtmare commented 1 month ago

I've rebased and changed 9.4.5 to 9.4.8 and 9.6.2 to 9.6.6 with the latest stackage lts.

noughtmare commented 1 month ago

Oh, now the golden tests have changed again

noughtmare commented 1 month ago

Now it might work. There are still two things that could be updated:

tomjaguarpaw commented 1 month ago

Cool, thanks! If you feel like making the other updates then please do, but for things like tested-with I find them too difficult to keep up to date if they're not checked by tooling.

tomjaguarpaw commented 1 month ago

Feel free to create another PR with the updates above.

@noughtmare @willbasky @Vekhir thanks for pushing this through!

Vekhir commented 1 month ago

@tomjaguarpaw Thanks for merging! Quick question: Do you also have the permissions to push Hackage releases? That would be quite useful in combination with this PR.

tomjaguarpaw commented 1 month ago

I've asked Veronika and she says she can give me Hackage permissions in a couple of weeks.

Vekhir commented 1 month ago

Alright.