kowainik / summoner

🔮 🔧 Tool for scaffolding batteries-included production-level Haskell projects
https://kowainik.github.io/projects/summoner
Mozilla Public License 2.0
702 stars 73 forks source link

Function "readFileText" deprecated in relude 1.1 #573

Open Vekhir opened 1 year ago

Vekhir commented 1 year ago

When building summoner using relude 1.2.0.0, the following warning occurs:

[11 of 23] Compiling Summoner.Source

src/Summoner/Source.hs:92:35: warning: [-Wdeprecations]
    In the use of ‘readFileText’
    (imported from Prelude, but defined in relude-1.2.0.0:Relude.File):
    "'readFileText' depends on the system's locale settings and can throw unexpected exceptions.
     Use 'readFileBS' instead."
   |
92 |     Local path -> catch (Just <$> readFileText path) (localError path)
   |                                   ^^^^^^^^^^^^

The relude Changelog mentions this change in v1.1.0.0 and also suggests a fix:

Use readFileBS / readFileLBS instead to convert to Text / LText / String using decodeUtf8 and similar functions.

With that change, the supported version for relude can be bumped to 1.2.0.0