Closed JekaMas closed 6 years ago
@acroca @rgeraldes @jmatosp looking forward for review
Reopen
@rgeraldes It'd be great if you have some time to review the PR.
@acroca @yourheropaul @jmatosp Is there any one brave for review?
@yourheropaul @johnreitano @jmatosp @rgeraldes review, pleeeeeeeeeaaase! This PR is waiting for review for far too long time.
Important changes:
nil
votes (against a block)nil
votes on quorum step. It prevents 'nil' block announce.common.Hash{}
- restore the consensusDuplicate votes are still present, but only in case if validator receives a few identical votes from different peers. So it works just fine now and doesn't corrupt StateDB.
The only issue that is not solved is https://github.com/kowala-tech/kcoin/issues/650
Closes #641 https://github.com/kowala-tech/kcoin/issues/297 https://github.com/kowala-tech/kcoin/issues/607 https://github.com/kowala-tech/kcoin/issues/529 https://github.com/kowala-tech/kcoin/issues/524